Repository navigation
Conversation
MDEC table handlers pop fixed numbers of halfwords, but save states could restore smaller remaining counts. A later command execution underflowed the input FIFO size and could stall future serialization. Reject inconsistent pending table commands and reset MDEC before returning so failed nontransactional loads remain safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MDEC::DoState()accepted pendingSetIqTableandSetScaleTablecommands with inconsistentm_remaining_halfwordsvalues. A laterMDEC::Execute()call could dispatch a handler that pops a fixed number of entries fromm_data_in_fifo, underflowing its size. Subsequent state serialization could then loop over a near-UINT32_MAXentry count and hang a netplay client receiving a crafted rollback state.Validate the exact pending counts produced for IQ and scale table commands. Invalid states reset MDEC before being rejected so failed nontransactional rollback loads remain safe.