Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Contributor
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[DONE]in the shared search/vision parser. The terminal frame itself is still fully processed, and existing EOF, byte/decoded limits and cancellation behavior remain intact.Verification
Windows; Bun 1.4.4; independent commit on
devd0c8151a720ac2a42d32eea9b4fb76bff0072dc6, fetched at task start.web-search-eof.test.tsfailed 5 cases before the runtime fix (28 passed); the one-chunk cases differed from the fragmented cases.bun run test:changed ./tests/web-search/web-search-eof.test.ts ./tests/web-search/web-search-parse.test.ts ./tests/web-search/fix-search-frame-shapes.test.ts ./tests/web-search/web-search.test.ts ./tests/web-search/web-search-terminal-refusal.test.ts ./tests/vision/vision-routed.test.ts ./tests/vision/vision-fail-closed.test.ts --parallel=1 --timeout 30000— 201 passed / 0 failed / 602 assertions, 7 files, 24.86 seconds.bun run typecheck— passed, 2,317 files.bun run structure:check,bun scripts/file-size-ratchet.ts,bun run privacy:scan,git diff --check— passed. Structure checking was repeated after moving the contract paragraph to avoid a documentation merge conflict with fix(sidecars): replace repeated text-done snapshots #8197.cd docs-site; bun install --frozen-lockfile; bun run build— passed, 641 pages / 93,150 checked internal links. Existing chunk-size warnings remain.bun test --no-env-file --isolate ./tests/lib/fix-jsonc-cr-comments.test.ts ./tests/lib/fix-jsonc-empty-comma.test.ts ./tests/lib/token-estimate.test.ts ./tests/web-search/web-search-eof.test.ts ./tests/web-search/web-search-parse.test.ts ./tests/web-search/fix-search-frame-shapes.test.ts ./tests/web-search/web-search-sources.test.ts --timeout 30000— 174 passed / 0 failed / 357 assertions, 7 files, 3.35 seconds. The preview merge was aborted; this branch contains only its terminal-boundary fix.The changed-test command restricts discovery to the listed files and one worker, with
OCX_TEST_MAIN_TIMEOUT_MS=120000. A previous unrestricted import-graph run on this Windows host reached 900 seconds with timing/teardown failures; it is not passing evidence for this head. Full unrestricted changed-graph/full-suite and non-Windows execution remain unverified and are left to CI/independent review. All provider streams are synthetic; no live account or native client was used. This PR remains Draft.Checklist
Review readiness checklist
This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:
Required local validation passed; commands, results, and any full-suite exception are documented.
I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
I resolved all correct Codex and CodeRabbit findings.
My PR is ready for review.