Repository navigation
Re-land #8389: fix(copilot): keep Auto negotiation off real DNS in tests and survive a mid-negotiation account switch - #8408
Merged
Merged
Conversation
… a mid-negotiation account switch (#8389) * fix(copilot): keep Auto negotiation off real DNS in account-origin tests The account-origin fixture stubbed globalThis.fetch, but Copilot Auto's /models negotiation runs on providerOutboundGet, which resolves and pins a real peer address before calling the provider executor. Every case therefore performed a real DNS/TLS request to <account>.githubcopilot.com/models, bypassing the fixture. Under CI network latency that request took 5s or 10s, timing out the test in whichever case happened to be negotiating. Hand the fixture's fetch to the provider via the existing stubbedProviderFetch helper, serve /models from the fixture, and reset the Auto catalog cache per case. This also exposed a production bug: when the account changed while the negotiation was queued, beforeSend cancelled the control-plane send and resolveCopilotAuto treated that as fatal. A manual selection change now falls back to the requested model so dispatch can revalidate and rebuild on the new account; a client abort still rejects. Failing-first: the new regression asserts the fixture saw /models and failed with modelsRequests=[] before the provider executor was attached. * fix(copilot): fall back on an account switch during the Auto session and intent sends too (cherry picked from commit 1176557)
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
3 tasks done
Contributor
|
✅ Deterministic PR hygiene checks passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-lands #8389 (original squash 1176557), which was reverted in #8402 together with the other PRs that were admin-merged on 2026-11-09. Cherry-picked unchanged onto current
dev(git cherry-pick -x).Verification
--adminon that evidence. Pushed with--no-verify. NOT RUN: CI on this re-land head.Checklist