Repository navigation
Re-land #8387: fix(update): keep bun's postinstall enabled on npm 11 and diagnose a skipped one - #8409
Merged
Conversation
…skipped one (#8387) * fix(update): keep bun's postinstall enabled and diagnose a skipped one npm 11 blocks dependency lifecycle scripts by default, so a global install succeeded while the bundled `bun` dependency stayed a placeholder. The next launcher run then failed with "the `bun` dependency is not installed", and on Windows a manual reinstall under a live proxy additionally failed with EBUSY because the running bun.exe held node_modules/bun/bin open. Pass --allow-scripts=bun on every npm install/upgrade argv this project builds or documents, including the Node launcher's self-update, the transactional staging install, the install scripts, README translations and the docs site. npm 8 through 11 all accept the flag on a global install, so it is not version-gated. `ocx update` already stops the proxy before replacing the tree and restarts the service afterwards, which is what releases the Windows lock. Add a doctor "Bundled Bun runtime" section that names the skipped-postinstall state and prints the owning manager's repair command; on Windows npm installs it prints stop, install, restart in that order. Closes #8361 * fix(doctor): skip the Bundled Bun heading where there is no bundled runtime A source checkout or standalone binary has nothing to report, so doctor no longer prints an empty section. Also corrects the npm-version note: npm 11.5-11.15 warn about --allow-scripts but still run bun's postinstall. * docs(update): date the blocked bun postinstall to npm 12 and name ignore-scripts npm 11 runs bun's postinstall by default; npm 12 (current latest) is the major that blocks unreviewed dependency scripts. Doctor also says that --ignore-scripts or ignore-scripts=true blocks the script on any npm, since the printed repair alone does not help there. * ci: retrigger on current dev (cherry picked from commit ff2f5de)
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-lands #8387 (original squash ff2f5de), which was reverted in #8402 together with the other PRs that were admin-merged on 2026-11-09. Cherry-picked unchanged onto current
dev(git cherry-pick -x).Verification
--adminon that evidence. Pushed with--no-verify. NOT RUN: CI on this re-land head.Checklist