Repository navigation
Re-land #8384: fix(gui): recover Aside overwrite previews instead of failing silently - #8410
Merged
Merged
Conversation
#8384) * fix(gui): recover Aside overwrite previews instead of failing silently The Integrations Overview sent an aggregate Aside preview with no profile, which the server must refuse because a plan describes one profile's file. Conflicted Aside cards now route to the per-profile surface, where Replace is scoped and bound. A preview that answers 409 integration_preview_unavailable no longer closes the dialog. The Overview, the file page, and the Aside profile page keep it open and offer "Load catalog and retry", which performs the ordinary integration read that retains the export roster and then re-asks for the plan. Preview itself stays side-effect free. Closes #8354 * fix(gui): offer catalog recovery for bulk disable previews too Disable-all had the same silent close on integration_preview_unavailable. It now keeps its dialog and retries from the same ordinary collection read. Closes #8354 * fix(gui): disable confirm while a preview still needs the catalog A refused preview leaves no plan, so the confirm button must not look live while "Load catalog and retry" is the only action that can produce one. Closes #8354 * fix(gui): keep a closed integration dialog closed when its catalog recovery finishes (cherry picked from commit 62bba48)
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Contributor
⏳ DRAFT
What to do
Automatic draft conversion failed (token cannot change draft status). Please convert this pull request to a draft manually. The required |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-lands #8384 (original squash 62bba48), which was reverted in #8402 together with the other PRs that were admin-merged on 2026-11-09. Cherry-picked unchanged onto current
dev(git cherry-pick -x).Verification
--adminon that evidence. Pushed with--no-verify. NOT RUN: CI on this re-land head.Checklist