Skip to content

Re-land #8353: fix(integrations): stop warning about an uninstalled owned client on every model toggle - #8411

Merged
lidge-jun merged 1 commit into
devfrom
reland/pr-8353
Nov 9, 2026
Merged

lidge-jun merged 1 commit into
devfrom
reland/pr-8353

Conversation

@lidge-jun

Copy link
Copy Markdown
Owner

Summary

Re-lands #8353 (original squash 0a1d59e), which was reverted in #8402 together with the other PRs that were admin-merged on 2026-11-09. Cherry-picked unchanged onto current dev (git cherry-pick -x).

Verification

  • The original PR's exact-head CI passed before its first merge.
  • A post-merge independent review of 0a1d59e returned PASS, with P3 notes only.
  • The owner instructed re-landing with --admin on that evidence. Pushed with --no-verify. NOT RUN: CI on this re-land head.

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

…t refresh (#8353)

An ownership record outlives the client it describes: once ~/.pi was removed,
every model toggle and sync re-ran the owned refresh, the writer refused with
not_installed, and the dashboard showed "pi: pi is not installed" for a client
the user no longer has. Implicit refresh now treats an uninstalled client like
a never-connected one (null, left alone). The record is kept, so a reinstall
resumes refreshing; explicit enable still refuses with not_installed.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 0a1d59e)
@lidge-jun
lidge-jun requested a review from Ingwannu as a code owner November 9, 2026 01:01
@lidge-jun
lidge-jun merged commit 6dac511 into dev Nov 9, 2026
6 checks passed
@lidge-jun
lidge-jun deleted the reland/pr-8353 branch November 9, 2026 01:01
@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 8c812be and b50fbbf.

Files selected for processing: 2

  • src/integrations/owned-refresh.ts
  • tests/clients/sync-client-integrations.test.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-09T01:03:05.765780Z b50fbbf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant