Repository navigation
Re-land #8349: fix(codex): reclaim stale shim restore lock with several dead owners - #8413
Merged
Merged
Conversation
…8349) A codex-shim.autorestore.lock directory holding more than one owner record was unreadable, so reclaimStaleRestoreLock returned false before its stale-age and liveness checks ran and `ocx codex-shim install` reported "already in progress" forever. Read every entry as a token-named owner record and reclaim only when all owners are past the stale window with dead PIDs and the owner set, directory identity and fingerprints are unchanged on reread. Each owner is unlinked by its token name before the directory is removed. Any live, fresh or unaccounted entry still blocks reclaim, and release still removes only a lock its caller solely owns. Closes #8317 Co-authored-by: Ingwannu <ingwannu@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 9fb295b)
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 55 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-lands #8349 (original squash 9fb295b), which was reverted in #8402 together with the other PRs that were admin-merged on 2026-11-09. Cherry-picked unchanged onto current
dev(git cherry-pick -x).Verification
--adminon that evidence. Pushed with--no-verify. NOT RUN: CI on this re-land head.Checklist