Repository navigation
Re-land #8150: fix(google): clear replayed thought signatures on a real HTTP 400 (#8054) - #8414
Merged
Merged
Conversation
) (#8150) * fix(google): clear replayed thought signatures on a real HTTP 400 (#8054) The Antigravity/Vertex clear-on-invalid path (handleSignatureRejection) only ran for errors inside a 200 body or stream. A real HTTP 400 INVALID_ARGUMENT is returned by fetchGoogleWithRetry and reported by the dispatcher without calling the adapter parsers, so the rejected signature stayed in the session replay cache and was replayed on every turn until the 1h TTL expired. The adapter's fetchResponse wrapper now reads a clone of a final 400 body and runs the same invalidation, leaving the body the dispatcher formats untouched. No resend is added: payload rejection stays resend-is-futile. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(google): clear session replay on any Vertex/Antigravity HTTP 400 The normalized Google error text keeps only the upstream message, so a 400 whose message lacks "invalid argument" or "signature" (for example "bad model") left the rejected signature in the session replay cache. Pass the HTTP status to handleSignatureRejection so a real 400 counts as invalid-argument for the in-memory clear. Durable eviction stays gated on signature text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Ingwannu <ingwannu@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit e76511d)
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-lands #8150 (original squash e76511d), which was reverted in #8402 together with the other PRs that were admin-merged on 2026-11-09. Cherry-picked unchanged onto current
dev(git cherry-pick -x).Verification
--adminon that evidence. Pushed with--no-verify. NOT RUN: CI on this re-land head.Checklist