Refactor channel opens and payment sends into separate methods.#126
Open
arik-so wants to merge 2 commits intolightningdevkit:mainfrom
Open
Refactor channel opens and payment sends into separate methods.#126arik-so wants to merge 2 commits intolightningdevkit:mainfrom
arik-so wants to merge 2 commits intolightningdevkit:mainfrom
Conversation
tnull
reviewed
Nov 22, 2023
| var usableChannelsB = [ChannelDetails]() | ||
| print("Awaiting usable channels to populate…") | ||
| while (usableChannelsA.isEmpty || usableChannelsB.isEmpty) { | ||
| while (usableChannelsA.count == initialChannelsA.count || usableChannelsB.count == initialChannelsB.count) { |
Collaborator
There was a problem hiding this comment.
I'm confused: why would usableChannelsA not be empty here, we just intitialized it with an empty list, no?
|
|
||
| // STEP 1: CREATE INVOICE FROM RECIPIENT | ||
| let amtMsat = useZeroValueInvoice ? nil : milliSatoshiAmount | ||
| let invoiceResult = Bindings.createInvoiceFromChannelmanager(channelmanager: recipientPeer.channelManager, nodeSigner: recipientPeer.explicitKeysManager.asNodeSigner(), logger: logger, network: .Bitcoin, amtMsat: amtMsat, description: "Invoice description", invoiceExpiryDeltaSecs: 60, minFinalCltvExpiryDelta: 24) |
Collaborator
There was a problem hiding this comment.
Let's wrap this line. Generally this probably should be swift-formated?
| let routeParameters = RouteParameters(paymentParamsArg: paymentParameters, finalValueMsatArg: amount, maxTotalRoutingFeeMsatArg: nil) | ||
| let randomSeedBytes: [UInt8] = [UInt8](repeating: 0, count: 32) | ||
| let scoringParams = ProbabilisticScoringDecayParameters.initWithDefault() | ||
| // let networkGraph = senderPeer.constructor!.netGraph! |
Collaborator
There was a problem hiding this comment.
nit: Commented-out lines can be removed.
| do { | ||
| // process payment | ||
| let peer2Event = try! await recipientPeer.getManagerEvents(expectedCount: 1)[0] | ||
| guard case .PaymentClaimable = peer2Event.getValueType() else { |
Collaborator
There was a problem hiding this comment.
Any chance we can start DRYing some things up while we're here, e.g., making these 'expect event X' checks a util method or macro?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.