Skip to content

Conversation

@frnandu
Copy link

@frnandu frnandu commented Dec 29, 2025

fixes #74

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Dec 29, 2025

👋 Thanks for assigning @tankyleo as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull tnull requested review from tankyleo and removed request for jkczyz December 30, 2025 08:22
@ldk-reviews-bot
Copy link

🔔 1st Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot
Copy link

🔔 2nd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot
Copy link

🔔 3rd Reminder

Hey @tankyleo! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

Copy link
Contributor

@tankyleo tankyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! can you make this one commit / remove the merge commit in the current PR ?

@frnandu frnandu changed the title Chore/rust dockerfile chore: rust dockerfile Jan 15, 2026
Copy link
Contributor

@tankyleo tankyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above, let's bring back ca-certificates for HTTPS requests.

Also squash all the commits into a single one.

@frnandu frnandu force-pushed the chore/rust-dockerfile branch 3 times, most recently from fcec5ff to 2336a2d Compare January 24, 2026 15:35
@frnandu
Copy link
Author

frnandu commented Jan 24, 2026

Also squash all the commits into a single one.

Isn't that possible to do when merging by squash and merge ?

@tankyleo
Copy link
Contributor

Isn't that possible to do when merging by squash and merge ?

I need to ACK the exact commit that will get merged, should be quite doable on your side no ?

@tankyleo
Copy link
Contributor

@frnandu making sure you see this message above thanks for squashing if you can

@frnandu frnandu force-pushed the chore/rust-dockerfile branch from 2336a2d to 7f34829 Compare February 1, 2026 23:06
@frnandu
Copy link
Author

frnandu commented Feb 1, 2026

Squashed, thanks!

Copy link
Contributor

@tankyleo tankyleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks tested on my machine looks good.

One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dockerfile for rust version

4 participants