-
Notifications
You must be signed in to change notification settings - Fork 21
chore: rust dockerfile #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
|
🔔 1st Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @tankyleo! This PR has been waiting for your review. |
tankyleo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! can you make this one commit / remove the merge commit in the current PR ?
tankyleo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned above, let's bring back ca-certificates for HTTPS requests.
Also squash all the commits into a single one.
fcec5ff to
2336a2d
Compare
Isn't that possible to do when merging by |
I need to ACK the exact commit that will get merged, should be quite doable on your side no ? |
|
@frnandu making sure you see this message above thanks for squashing if you can |
2336a2d to
7f34829
Compare
|
Squashed, thanks! |
tankyleo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks tested on my machine looks good.
One last nitpick before merge: please set the title to Add rust Dockerfile, no need for the chore prefix thank you, I want to keep the commit log consistent.
fixes #74