fix: guard against short reservation id when printing shortid

[Olexandr88]

Guard against slicing ReservationId when printing the short ID to avoid a potential panic if the identifier is shorter than expected

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a defensive programming measure to enhance the robustness of the instantOut command. It specifically addresses a potential runtime panic that could occur if a ReservationId is unexpectedly short, ensuring the application continues to function reliably when displaying reservation information.

Highlights

• Panic Prevention: Implemented a length check for ReservationId before slicing to prevent a potential panic if the ID is shorter than expected when generating a short ID for display.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• cmd/loop/instantout.go
  • Added a length check for ReservationId to prevent slicing a short string and causing a panic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly guards against a potential panic that could occur when printing a short reservation ID. The added check on the length of the ReservationId before slicing it is a good defensive measure. I have one minor suggestion to improve the clarity of the conditional logic, making it more idiomatic.

[starius]

I reformatted it to follow the code style guide (formatting of fmt.Errorf). Also minimized the diff.

diff --git a/cmd/loop/instantout.go b/cmd/loop/instantout.go
index 5a558f2..a071529 100644
--- a/cmd/loop/instantout.go
+++ b/cmd/loop/instantout.go
@@ -89,6 +89,12 @@ func instantOut(ctx context.Context, cmd *cli.Command) error {
        fmt.Printf("Available reservations: \n\n")
        for _, res := range confirmedReservations {
                idx++
+               if len(res.ReservationId) != reservation.IdLength {
+                       return fmt.Errorf("invalid reservation id length: "+
+                               "got %d, expected %d", len(res.ReservationId),
+                               reservation.IdLength)
+               }
+
                fmt.Printf("Reservation %v: shortid %x, amt %v, expiry "+
                        "height %v \n", idx, res.ReservationId[:3], res.Amount,
                        res.Expiry)

Could you update the PR to have just a single commit with this diff, please?

[starius]

Could you rebase the PR, please? We recently enabled AI flow for low-severity PRs and this is a good candidate to validate it.

[Olexandr88]

Rebased on latest master