wavewalletrpc: fix the sweep_all doc comment's flag spelling - #1075
Merged
Conversation
The OnchainAddressRequest.sweep_all comment points readers at `wavecli send --send-all`, but the flag the CLI registers is `--sweep-all`. Correct the spelling so the comment (and the API reference generated from it downstream) names a flag that exists. Comment-only change; the stubs are regenerated via `make rpc`.
ellemouton
approved these changes
Jul 30, 2026
sputn1ck
added
the
backport-v0.1.x-branch
|
Successfully created backport PR for |
sputn1ck
added a commit
that referenced
this pull request
Jul 31, 2026
…ranch [v0.1.x-branch] Backport #1075: wavewalletrpc: fix the sweep_all doc comment's flag spelling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
OnchainAddressRequest.sweep_alldoc comment tells readers to usewavecli send --send-all, but the flag the CLI registers is--sweep-all. Anyone copying the invocation from the comment (or from the API reference the SDK generates from it) hits an unknown-flag error.This corrects the spelling in
wallet.protoand regenerates the stubs withmake rpc. Comment-only, no wire or behavior change.Flagged by review on the SDK sync PR (lightninglabs/wavelength-sdk#65), where the typo surfaces in the generated API reference data. It would be good to backport this to
v0.1.x-branchso the nextv0.1.1tag carries the fix and the SDK picks it up at its next pin bump.