Skip to content

Fix wasm-target hygiene in masonry_core#1731

Merged
waywardmonkeys merged 1 commit intolinebender:mainfrom
waywardmonkeys:wasm-improvements
Apr 13, 2026
Merged

Fix wasm-target hygiene in masonry_core#1731
waywardmonkeys merged 1 commit intolinebender:mainfrom
waywardmonkeys:wasm-improvements

Conversation

@waywardmonkeys
Copy link
Copy Markdown
Contributor

@waywardmonkeys waywardmonkeys commented Apr 13, 2026

This doesn't yet enable them in CI as that requires more work for tests and the feature matrix.

@waywardmonkeys
Copy link
Copy Markdown
Contributor Author

In #1723, masonry_imaging adds a dependency on masonry_core and then these fixes for compilation were needed.

This doesn't yet enable them in CI as that requires more work
for tests and the feature matrix.
Copy link
Copy Markdown
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do want to see if we can get Wasm support to be a thing, so I guess this makes sense.

@waywardmonkeys waywardmonkeys added this pull request to the merge queue Apr 13, 2026
@waywardmonkeys
Copy link
Copy Markdown
Contributor Author

Yeah, have to change the use of block_on in masonry_winit and set up font data ...

@waywardmonkeys
Copy link
Copy Markdown
Contributor Author

And fix feature matrix issues.

Merged via the queue into linebender:main with commit 9274fcc Apr 13, 2026
17 checks passed
@waywardmonkeys waywardmonkeys deleted the wasm-improvements branch April 13, 2026 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants