Bump linkedin/iceberg to 1.2.0.23 / 1.5.2.20 (ORC initial-defaults) - #701
Open
cbb330 wants to merge 1 commit into
Open
Bump linkedin/iceberg to 1.2.0.23 / 1.5.2.20 (ORC initial-defaults)#701cbb330 wants to merge 1 commit into
cbb330 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps both OpenHouse Iceberg pins so Spark 3.1 and Spark 3.5 pick up the ORC/Spark initial-default read path (
idToConstant) and the complete-embedded-field-id omit rule.iceberg_1_2_version:1.2.0.20→1.2.0.23(published asv1.2.0.23)iceberg_1_5_version:1.5.2.17→1.5.2.20(next two Shipkit tags after currentv1.5.2.18, once linkedin/iceberg#273 then linkedin/iceberg#274 merge)CI is expected to fail resolving
1.5.2.20until those Iceberg PRs merge and Shipkit publishes the tags. Rerun CI afterv1.5.2.20exists. Does not include linkedin/iceberg#269.Changes
Spark/ORC readers fill missing columns from Iceberg initial defaults via
idToConstant, and skip that fill only when the file already embeds a complete field-id set.1.2 line: linkedin/iceberg#267 (
v1.2.0.22) and linkedin/iceberg#268 (v1.2.0.23), plus CI-only linkedin/iceberg#266 (v1.2.0.21).1.5 line: linkedin/iceberg#257 is already
v1.5.2.18; #273 / #274 are the 1.5 twins of #267 / #268 and becomev1.5.2.19/v1.5.2.20if they are the next two merges onopenhouse-1.5.2.Testing Done
Version pin only. Iceberg coverage lives in linkedin/iceberg #267/#268 and #273/#274.
Additional Information
Depends on merge order 273 then 274 on
linkedin/iceberg(openhouse-1.5.2). Retarget 274 ontoopenhouse-1.5.2after 273 lands. If anotheropenhouse-1.5.2PR merges first, the 1.5 pin needs to move to the actual tag that contains #274.