fix(destination): properly deal with native sidecar port opacity in getProfile #14791
+54
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etProfile (Extracted from #14566) When hitting pods directly at their their IPs, ports in native sidecars that were marked as opaque via the `config.linkerd.io/opaque-ports` annotation, weren't really being marked as opaque. More concretely, the issue layed in the getProfile API, that was forgoing init containers when iterating over containers in this particular case. Endpoint profile translator tests got expanded, testing for opaque ports in both init and regular containers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Extracted from #14566)
When hitting pods directly at their their IPs, ports in native sidecars that were marked as opaque via the
config.linkerd.io/opaque-portsannotation, weren't really being marked as opaque.More concretely, the issue layed in the getProfile API, that was forgoing init containers when iterating over containers in this particular case.
Endpoint profile translator tests got expanded, testing for opaque ports in both init and regular containers.