-
Notifications
You must be signed in to change notification settings - Fork 1
[codex] Add configurable literal bracket patterns #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cmungall
wants to merge
1
commit into
main
Choose a base branch
from
feat/issue-43
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -23,7 +23,8 @@ class SupportingTextValidator: | |||||
| appears in the referenced publication using deterministic substring matching. | ||||||
|
|
||||||
| Supports: | ||||||
| - Editorial notes in [square brackets] that are ignored | ||||||
| - Editorial notes in [square brackets] that are ignored by default | ||||||
| - Configurable literal bracket patterns for bracketed source text | ||||||
| - Multi-part quotes with "..." separators indicating omitted text | ||||||
|
|
||||||
| Examples: | ||||||
|
|
@@ -46,6 +47,9 @@ def __init__(self, config: ReferenceValidationConfig): | |||||
| """ | ||||||
| self.config = config | ||||||
| self.fetcher = ReferenceFetcher(config) | ||||||
| self._literal_bracket_regexes = [ | ||||||
| re.compile(pattern) for pattern in config.literal_bracket_patterns | ||||||
| ] | ||||||
|
|
||||||
| def validate_title( | ||||||
| self, | ||||||
|
|
@@ -287,7 +291,7 @@ def find_text_in_reference( | |||||
| return self._substring_match(query_parts, reference.content, supporting_text) | ||||||
|
|
||||||
| def _split_query(self, text: str) -> list[str]: | ||||||
| """Split query into parts separated by ... removing [...] editorial notes. | ||||||
| """Split query into parts while stripping editorial brackets by default. | ||||||
|
|
||||||
| Args: | ||||||
| text: Query text | ||||||
|
|
@@ -302,12 +306,28 @@ def _split_query(self, text: str) -> list[str]: | |||||
| ['protein functions', 'in cells'] | ||||||
| >>> validator._split_query("protein [important] functions") | ||||||
| ['protein functions'] | ||||||
| >>> config = ReferenceValidationConfig(literal_bracket_patterns=[r"\\d"]) | ||||||
|
||||||
| >>> config = ReferenceValidationConfig(literal_bracket_patterns=[r"\\d"]) | |
| >>> config = ReferenceValidationConfig(literal_bracket_patterns=[r"\d"]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README says preserved bracketed text is kept "verbatim during validation", but the validator normalizes punctuation/whitespace before substring matching (and
_split_query()also collapses whitespace). Consider rewording to “preserved (not stripped) before normalization/validation” to avoid implying exact byte-for-byte matching.