Skip to content

Drain texture cache while capture is stopped (#26) #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aldoborrero wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drain texture cache while capture is stopped (#26) #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion pixelflux/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ use smithay::{
},
gles::GlesRenderer,
pixman::PixmanRenderer,
Bind, ImportAll, ImportEgl, ImportMem,
Bind, ImportAll, ImportEgl, ImportMem, Renderer,
},
},
desktop::{space::SpaceRenderElements, Space},
Expand Down Expand Up @@ -2388,6 +2388,18 @@ fn run_wayland_thread(
}

if !state.is_capturing && state.pending_screenshot.is_none() {
// While capture is stopped the render tick early-outs
// without finishing a Frame, so Smithay never drains its
// deferred texture-destruction queue: GPU buffers imported
// from nested clients that keep rendering accumulate and are
// only released on the next start_capture(). Drain the cache
// here so an idle session does not grow unbounded. On an
// integrated GPU these buffers are system RAM, so the leak
// surfaces as RSS growth and eventual OOM.
// Upstream: linuxserver/pixelflux#26, smithay#1747.
if let Some(renderer) = state.gles_renderer.as_mut() {
let _ = renderer.cleanup_texture_cache();
}
return TimeoutAction::ToDuration(Duration::from_millis(16));
}

Expand Down