Disable backoff behavior when near OOM conditions#18
Merged
Conversation
When Redis is using a lot of memory (90% of available), we want to disable queue backoff behavior. There is a significant risk that the backoff behavior will take jobs from the queue, and immediately try and reschedule them. If that happens in an OOM condition, the re-push will fail and the job can be lost. Additionally, the backoff behavior causes delays that slow down the clearing of the queue. In these high-memory-utilization conditions, it makes more sense to disable the backoff logic and just brute force to try to get through the queue.
rgalanakis
force-pushed
the
oom-disable-backoff
branch
from
79c2e40 to
d3deeca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Redis is using a lot of memory (90% of available), we want to disable queue backoff behavior.
There is a significant risk that the backoff
behavior will take jobs from the queue,
and immediately try and reschedule them.
If that happens in an OOM condition,
the re-push will fail and the job can be lost.
Additionally, the backoff behavior causes delays that slow down the clearing of the queue.
In these high-memory-utilization conditions,
it makes more sense to disable the backoff logic
and just brute force to try to get through the queue.