Add RetryOrDie callback support#23
Merged
Merged
Conversation
Callers can provide a subclass with two methods that are looked for: If on_retry is defined, it is called with (worker instance, job hash). If on_retry returns +:skip+, do NOT retry (do not send to the retry set). If on_die is defined, it is called with (worker instance, job hash). If on_die returns +:skip+, do NOT send to the dead set.
Also add an explicit test for `.to_not publish` (with no name)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage ? 98.28%
=======================================
Files ? 36
Lines ? 2626
Branches ? 0
=======================================
Hits ? 2581
Misses ? 45
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callers can provide a subclass with two methods that are looked for:
If on_retry is defined, it is called with (worker instance, job hash). If on_retry returns +:skip+, do NOT retry (do not send to the retry set).
If on_die is defined, it is called with (worker instance, job hash). If on_die returns +:skip+, do NOT send to the dead set.