Repository navigation
build(deps): override smol-toml to 1.7.1 - #1755
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The override is correctly scoped to nx and the lockfile reflects smol-toml@1.7.1 as the resolved installed version.
Pull request overview
This PR mitigates a high-severity vulnerability by using an npm overrides rule to replace Nx’s transitive dependency on smol-toml@1.6.1 with the patched smol-toml@1.7.1, while keeping the override scoped to Nx rather than applying it globally across the workspace.
Changes:
- Add a scoped npm override so only
nxresolvessmol-tomlto1.7.1. - Update
package-lock.jsonto reflectsmol-toml@1.7.1as the installed version.
File summaries
| File | Description |
|---|---|
| package.json | Adds a scoped overrides.nx.smol-toml = 1.7.1 rule to address the vulnerability without a repo-wide override. |
| package-lock.json | Updates the resolved node_modules/smol-toml entry to 1.7.1 (including updated integrity metadata). |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
JoannaSikora
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
smol-toml@1.6.1used by Nx with patched1.7.1Nx currently hard-pins
smol-toml@1.6.1. The latest compatible Nx 22 release, as well as Nx 23.2.1, still uses that vulnerable version, so a parent-package bump cannot resolve the alert yet.Dependabot alert: https://github.com/livechat/design-system/security/dependabot/507
Validation
npm explain smol-tomlresolves1.7.1through the scoped overridenpm auditreports 0 High and 0 Critical vulnerabilitiesnpm testnpm run build