feat(google): preserve thought signatures for Gemini 3+ function calling #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
Author
|
I also made an issue here #920 |
Contributor
Author
|
Wait, I've got a few issues, do not merge |
- Add thoughtSignature field to FunctionCall class in chat_context.ts - Capture thoughtSignature from API response in google plugin llm.ts - Include thoughtSignature when converting back to Google format - Preserve thoughtSignature in voice/generation.ts when recreating FunctionCall - Update @google/genai to v1.34.0 for thoughtSignature support
tomc98
force-pushed
the
fix/thought-signature-function-calling
branch
from
b99fa73 to
80138a6
Compare
Contributor
Author
|
Ok ready for review :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Gemini 3+ models require thought signatures to be preserved and returned when using function calling with thinking mode enabled. Without this fix, the API returns a 400 error:
Changes
thoughtSignatureoptional field toFunctionCallclassthoughtSignaturefrom Gemini API response in Google plugin's#parsePartmethodthoughtSignaturewhen converting chat context back to Google formatisEquivalentto comparethoughtSignaturefor function callsModels affected
This fix enables compatibility with:
gemini-3-flash-previewgemini-3-flash-lite-previewgemini-3-pro-previewReferences
Test plan