Open
Conversation
1egoman
reviewed
Apr 14, 2026
1egoman
left a comment
1egoman
left a comment
There was a problem hiding this comment.
Generally makes sense to me, I'm not a flutter expert though so it would be good to also get a review from somebody who is.
Comment on lines
87
to
+105
| SessionOptions({ | ||
| Room? room, | ||
| this.preConnectAudio = true, | ||
| this.agentConnectTimeout = const Duration(seconds: 20), | ||
| }) : room = room ?? Room(); | ||
| this.encryption, | ||
| }) : isRoomProvided = room != null, | ||
| room = room ?? Room() { | ||
| _validateEncryptionConfiguration(); | ||
| } | ||
|
|
||
| SessionOptions._({ | ||
| required this.room, | ||
| required this.isRoomProvided, | ||
| required this.preConnectAudio, | ||
| required this.agentConnectTimeout, | ||
| this.encryption, | ||
| }) { | ||
| _validateEncryptionConfiguration(); | ||
| } |
There was a problem hiding this comment.
This might be a bad / nonsensical suggestion as I am not too familiar with typical flutter patterns, but would be worthwhile to get all session initialization (constructor and alternate constructor paths like the copyWith static method) going through the same core _ static method for initialization?
xianshijing-lk
approved these changes
Apr 14, 2026
Contributor
xianshijing-lk
left a comment
xianshijing-lk
left a comment
There was a problem hiding this comment.
one question and look good to me
| // Restart: the E2EE manager already exists from a previous session. | ||
| // Re-enable in case it was toggled off, before connect publishes | ||
| // any tracks. | ||
| await room.setE2EEEnabled(true); |
Contributor
There was a problem hiding this comment.
curiously, do we need to pass the encryption over to the room in this case ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.