Open
Conversation
This is partly based on llllllllll#14 This fixes the test_self_in_closure test, but one async_generator test still fails. That is because the way we used to drive the async generator for testing no longer works in 3.8, even before the cloudpickle round trip. I've marked it as xfail for now.
This requires a few changes in the C extension. (This is now tested to work in python3.8 up to python3.10)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The python 3.8 support is partly based on #14. All (but one; see below) tests
pass in python 3.7 to python 3.10 (I haven't tested earlier version but I don't
expect them to fail)
test_async_generator_1fails in python 3.8, but I believe this is not relatedto
cloudpickle-generatorsat all; theasyncgen_asgenfunction fails toconvert the original async generator into a generator (even before the
cloudpickle roundtrip). I haven't looked too deeply into this, but I think that
should be addressed in a separate PR/issue.
Python 3.11 support would require a lot more work, as the internals of frame
objects was reworked.