Correction for bit jaccard - #264
Open
TommasoTarchi wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Regarding the tests, I modified them to avoid rewriting a correct bit_jaccard routine (which would only be used for testing purposes). The drawback is that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
bit_jaccardroutine is implemented using the negative log transform, likealternative_jaccard. Therefore, a correction to the final distances should be applied.To avoid writing an additional correction function, we switched from log to log2 transform, making it coherent with
alternative_jaccard. If there are reasons to keep log instead of log2, then a new correction function has to be written.