Repository navigation
Update Spark SDK to 0.13.0 - #25
Open
blackcoffeexbt wants to merge 1 commit into
Open
blackcoffeexbt wants to merge 1 commit into
blackcoffeexbt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Spark SDK from 0.9.0 to 0.13.0 and updates payment retries to the changed latest API.
Spark SDK now requires a UUID transferId instead of the old idempotencyKey. The sidecar derives this ID from the network and invoice payment hash, so retries reuse the same ID across restarts, invoice casing changes, and fee allowance changes. This preserves duplicate-payment protection under the new API.
Also updates:
Validation: all 43 tests and formatting checks pass, the Nix build succeeds, and npm reports zero vulnerabilities. Live payments have been manually tested against LNbits 1.6.2