Skip to content

Update Spark SDK to 0.13.0 - #25

Open
blackcoffeexbt wants to merge 1 commit into
mainfrom
chore/spark-sdk-1.13
Open

blackcoffeexbt wants to merge 1 commit into
mainfrom
chore/spark-sdk-1.13

Conversation

@blackcoffeexbt

Copy link
Copy Markdown
Contributor

Updates Spark SDK from 0.9.0 to 0.13.0 and updates payment retries to the changed latest API.

Spark SDK now requires a UUID transferId instead of the old idempotencyKey. The sidecar derives this ID from the network and invoice payment hash, so retries reuse the same ID across restarts, invoice casing changes, and fee allowance changes. This preserves duplicate-payment protection under the new API.

Also updates:

  • Tests to verify the ID reaches Spark’s transfer, preimage swap, and provider request.
  • Updated the incoming-payment test to verify that the SDK returns each receiver’s ID.
  • Updated gRPC dependency to 1.14.5, resolving its reported security advisory.

Validation: all 43 tests and formatting checks pass, the Nix build succeeds, and npm reports zero vulnerabilities. Live payments have been manually tested against LNbits 1.6.2

@motorina0 motorina0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants