Skip to content

1086 optimize ci workflows - #1135

Merged
digicosmos86 merged 6 commits into
mainfrom
1086-optimize-ci-workflows
Aug 5, 2026
Merged

1086 optimize ci workflows#1135
digicosmos86 merged 6 commits into
mainfrom
1086-optimize-ci-workflows

Conversation

@digicosmos86

@digicosmos86 digicosmos86 commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Some immediate improvements to our ci workflows

  1. Removed test step in the publish workflow
  2. Removed the setup python step in reusable workflows. No need for it because uv sets up Python
  3. Removed installation of lapack because sampling is done in numba now

Summary by CodeRabbit

  • Chores
    • Updated automated build environments and tooling for more consistent setup and dependency caching.
    • Improved Python environment setup across automated workflows.
    • Streamlined publishing so releases proceed after successful linting and type checks.
    • Simplified continuous integration by removing redundant full-test and notebook validation paths.
    • Cleaned up obsolete environment configuration from coverage and notebook checks.

@digicosmos86 digicosmos86 linked an issue Aug 4, 2026 that may be closed by this pull request
@digicosmos86
digicosmos86 requested review from AlexanderFengler, cpaniaguam and krishnbera and a lite review from Copilot August 4, 2026 18:03
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@digicosmos86, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ebba1c06-ff7b-467b-ba62-35a50349f88c

📥 Commits

Reviewing files that changed from the base of the PR and between baff9e3 and 5857790.

📒 Files selected for processing (3)
  • .github/setup-env-notebooks/action.yml
  • .github/workflows/check_notebooks.yml
  • .github/workflows/coverage.yml
📝 Walkthrough

Walkthrough

The CI environment actions now use updated checkout and uv setup actions. The publish workflow removes separate test jobs and conditional publishing. The coverage workflow removes its job-level PYTENSOR_FLAGS definition.

Changes

CI workflow updates

Layer / File(s) Summary
Environment bootstrap changes
.github/setup-env/action.yml, .github/setup-env-notebooks/action.yml
The composite actions update checkout and uv versions, pass the configured Python version to setup-uv, enable caching, and remove separate Python and BLAS/LAPACK setup.
Workflow execution changes
.github/workflows/build_and_publish.yml, .github/workflows/coverage.yml
The publish workflow removes the manual test-suite input, separate test jobs, and conditional publishing. The coverage workflow removes its job-level PYTENSOR_FLAGS definition.

Estimated code review effort: 2 (Simple) | ~15 minutes

Suggested reviewers: alexanderfengler, cpaniaguam, krishnbera

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: optimizing the CI workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 1086-optimize-ci-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/setup-env-notebooks/action.yml:
- Around line 14-18: Update the “Install uv” step in the setup-env-notebooks
action to pass the action’s declared python-version input to astral-sh/setup-uv,
ensuring uv sync --group notebook uses the selected matrix Python version.
Preserve the existing version and cache settings.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 7d4a919a-2538-487a-9a61-f9fbea8d7e8c

📥 Commits

Reviewing files that changed from the base of the PR and between 481a564 and 3b511ef.

📒 Files selected for processing (5)
  • .github/setup-env-notebooks/action.yml
  • .github/setup-env/action.yml
  • .github/workflows/build_and_publish.yml
  • .github/workflows/check_notebooks.yml
  • .github/workflows/coverage.yml
💤 Files with no reviewable changes (2)
  • .github/workflows/coverage.yml
  • .github/workflows/check_notebooks.yml

Comment thread .github/setup-env-notebooks/action.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes HSSM’s CI workflows by removing legacy BLAS/LAPACK-related configuration, simplifying environment setup to rely on uv, and streamlining the publish workflow.

Changes:

  • Removed PYTENSOR_FLAGS BLAS/LAPACK configuration from selected workflows and dropped OS-level BLAS/LAPACK installation from reusable composite actions.
  • Updated reusable composite actions to rely on astral-sh/setup-uv for Python provisioning instead of actions/setup-python.
  • Simplified the release publish workflow by removing the pre-publish full test-suite job and related workflow_dispatch input.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
.github/workflows/coverage.yml Removes job-level BLAS/LAPACK env configuration for coverage runs.
.github/workflows/check_notebooks.yml Removes job-level BLAS/LAPACK env configuration for notebook execution.
.github/workflows/build_and_publish.yml Removes optional/required full test-suite job before publishing releases.
.github/setup-env/action.yml Simplifies env setup by relying on setup-uv (and updates action versions).
.github/setup-env-notebooks/action.yml Simplifies notebook env setup by relying on setup-uv (and updates action versions).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/check_notebooks.yml
Comment thread .github/workflows/coverage.yml
Comment thread .github/setup-env-notebooks/action.yml
Comment thread .github/workflows/build_and_publish.yml
cpaniaguam
cpaniaguam previously approved these changes Aug 4, 2026

@cpaniaguam cpaniaguam left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Consider adding the python version to the install uv action for reproducibility.

With the job-level PYTENSOR_FLAGS removed, `${{ env.PYTENSOR_FLAGS }}`
expanded to an empty string and exported PYTENSOR_FLAGS=, blanking
PyTensor's defaults instead of leaving them alone. run_tests.yml still
sets an explicit value where the BLAS flags are needed.

Refs #1086

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@digicosmos86

Copy link
Copy Markdown
Collaborator Author

@codex review

@digicosmos86

Copy link
Copy Markdown
Collaborator Author

lgtm. Consider adding the python version to the install uv action for reproducibility.

Fixed

@digicosmos86
digicosmos86 merged commit 8114267 into main Aug 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize CI workflows

3 participants