Skip to content

Fixed numpy version - #1137

Open
digicosmos86 wants to merge 3 commits into
mainfrom
1136-fix-numpy-deprecations
Open

Fixed numpy version#1137
digicosmos86 wants to merge 3 commits into
mainfrom
1136-fix-numpy-deprecations

Conversation

@digicosmos86

@digicosmos86 digicosmos86 commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

numba still only supports numpy>=2.4.0, <2.5.0. However, dependency version resolving in CI can install numpy >= 2.5, which causes numba to break, because its source code still uses deprecated numpy functions, which are removed in numpy 2.5. This PR fixes this issue

This PR also updates the devcontainer and docker build workflows, so that they only run on merge to main when relevant files have changed. No need to run them at every push

Summary by CodeRabbit

  • Chores
    • Improved repository configuration and local development file handling.
    • Updated maintenance and quality-tooling settings for a more consistent development experience.
    • Refined environment settings to support current runtime and testing workflows.
    • Updated development workflows to validate changes on pushes to the main branch.
    • Enhanced Docker image automation for main-branch builds, releases, and multi-platform publishing.

@digicosmos86 digicosmos86 linked an issue Aug 5, 2026 that may be closed by this pull request
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The change updates local ignore rules, package version constraints, and GitHub Actions workflow triggers. Docker builds now select platform and push behavior based on the triggering event.

Changes

Repository configuration

Layer / File(s) Summary
Local artifact ignore rules
.codegraph/.gitignore, .gitignore
The ignore rules exclude local CodeGraph contents and .claude/CLAUDE.local.md.
Dependency constraints
pyproject.toml
Runtime requirements update absl-py, numpy, and numpyro. The direct scipy dependency is removed. Ruff and pytest minimum versions are raised.
Automation triggers and build modes
.github/workflows/devcontainer.yml, .github/workflows/docker-image.yml
The workflows add main-branch push handling. Docker builds use linux/amd64 for pushes and multi-architecture builds for releases and other supported events.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: updating the NumPy version constraint.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 1136-fix-numpy-deprecations

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pyproject.toml`:
- Around line 27-35: Restore SciPy in the [project.dependencies] list because
plotting modules quantile_probability.py and predictive.py import scipy.stats at
runtime. Add a compatible scipy version constraint alongside the existing
numerical dependencies, rather than removing the dependency while those imports
remain.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dec3f9ec-bf63-4d32-ab13-cb0816dfae87

📥 Commits

Reviewing files that changed from the base of the PR and between 8114267 and 53d2c0b.

📒 Files selected for processing (3)
  • .codegraph/.gitignore
  • .gitignore
  • pyproject.toml

Comment thread pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: numpy deprecations

1 participant