Fixed numpy version - #1137
Open
digicosmos86 wants to merge 3 commits into
Open
Conversation
Contributor
📝 WalkthroughWalkthroughThe change updates local ignore rules, package version constraints, and GitHub Actions workflow triggers. Docker builds now select platform and push behavior based on the triggering event. ChangesRepository configuration
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pyproject.toml`:
- Around line 27-35: Restore SciPy in the [project.dependencies] list because
plotting modules quantile_probability.py and predictive.py import scipy.stats at
runtime. Add a compatible scipy version constraint alongside the existing
numerical dependencies, rather than removing the dependency while those imports
remain.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: dec3f9ec-bf63-4d32-ab13-cb0816dfae87
📒 Files selected for processing (3)
.codegraph/.gitignore.gitignorepyproject.toml
when related files change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numbastill only supportsnumpy>=2.4.0, <2.5.0. However, dependency version resolving in CI can install numpy >= 2.5, which causesnumbato break, because its source code still uses deprecated numpy functions, which are removed in numpy 2.5. This PR fixes this issueThis PR also updates the devcontainer and docker build workflows, so that they only run on merge to main when relevant files have changed. No need to run them at every push
Summary by CodeRabbit