Add post beta tasks#3
Open
RainbowMango wants to merge 1 commit into
Open
Conversation
logicalhan
force-pushed
the
metrics-stability-beta
branch
from
a4559c8 to
264a1e5
Compare
Author
|
Hi Han, any other content is needed for this KEP? I can think of is |
logicalhan
pushed a commit
that referenced
this pull request
Aug 16, 2020
Added multi-node test scenarios
logicalhan
pushed a commit
that referenced
this pull request
Apr 8, 2021
Additional updates to PRR docs
logicalhan
pushed a commit
that referenced
this pull request
Jun 27, 2021
Ensure Implementation stategy captured in the KEP matches latest implementation
logicalhan
pushed a commit
that referenced
this pull request
Aug 18, 2022
chore: rename to `key_id` and use bytes for metadata
logicalhan
pushed a commit
that referenced
this pull request
Mar 21, 2023
…ategy (kubernetes#3661) * Initial KEP for improving pruning in kubectl apply * Add design details Co-authored-by: Katrina Verey <katrina.verey@shopify.com> * Add another open question * Links, clarifications, ownerRef and GKNN explanations * Follow-on to initial feedback, address some unresolved blocks * Fix lint errors * Add more detail about reference implementation (#2) * Apply prune jan25 (#3) * More clearly delineate specification vs kubectl details * Move design details of spec to Design Details section * Updates from synchronous conversation * Remove leftover paragraph (kubernetes#5) Not an alternative rejected any more, given applyset.k8s.io/inventory * Justin has always been coauthor * KEP-3659: production readiness etc (kubernetes#4) Fill in the testing/ PRR sections. * Fix test failures * Prune: document confused deputy attack and mitigations Likely pushes us to GKNN-derived IDs. * Constrain applyset id We just choose the constrained applyset id to prevent "applyset ID impersonation". * Update KEP and PRR metadata * Enhance testing description * ID vs name fixes * Fixes from soltysh's review --------- Co-authored-by: Justin Santa Barbara <justinsb@google.com>
logicalhan
pushed a commit
that referenced
this pull request
Sep 11, 2023
address review feedback (part 2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I guess post-beta tasks means the tasks that can be started after beta.
I also have thought if we should filter metrics from an endpoint.
E.g. now, if we get metrics by
curl localhost:10255/metrics, all metrics will be shown out.If there is a scenario that user just wants some specific metrics?
E.g.
curl localhost:10255/metrics/metrics_1&metrics_2. in this case ,only metrics_1 and metrics_2 will be shown.