Repository navigation
text: Prevent stale selections from returning after remount - #3588
Merged
huacnlee merged 2 commits intoOct 19, 2026
Merged
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A completed-frame sweep clears an unmounted participant's snapshot but leaves the window's anchor/cursor alive. Registering the same retained TextView state later republishes those endpoints, making its old selection copyable again without a new gesture.
Change
Retire the existing window selection state when an actually removed participant owns the anchor, cursor, or pending extension anchor. Reuse the existing clear path so auto-scroll stops before its anchor disappears, touch state resets, and clear callbacks still run outside the window-state update borrow. Cached views that remain rendered and unrelated participant removal preserve selection. No public API, dependency, or compatibility layer is added.
Verification
Reproducible native consumer probe
Temporarily place this in crates/kit/examples/selection_lifecycle.rs, then run on macOS:
The probe preserves the clipboard and never activates or shows its windows. App effects are flushed between completed frames. The temporary example is removed from the contribution after verification.