Repository navigation
typos: Ignore the two release-notes contributor handles - #3608
Merged
Merged
Conversation
The v0.8.0 release notes left the Checks job red on main: the tokenizer reads @UncertaintyDeterminesYou4ndMe as "nd" and @alex-vas as "vas". Ignore the exact handle strings, so the handles stay verbatim and the rest of release-notes.md (and the repo) remains fully checked.
huacnlee
added a commit
that referenced
this pull request
Oct 24, 2026
The valid Portuguese translations introduced by #3638 cause the pinned typos 1.40.0 checker to report three false positives on main ([failing Checks job](https://github.com/longbridge/gpui-kit/actions/runs/39989920902/job/120538735238)). Add three exact `pt-BR` expression exceptions, following #3608. Translations remain unchanged; no global word exemption or file exclusion is added. Validation with the official typos-cli 1.40.0 release, verified against its published SHA-256: - Full repository before: exactly three findings, exit 2; after: exit 0. - Negative controls still detect English `atual`, `Atual`, and `seperate` in source, English locale entries, and the locale file itself. - Translation bytes unchanged; `git diff --check` passes. - Independent review cleared the exact four-line patch. Rust tests were not run for this configuration-only change. Prepared with ChatGPT assistance on behalf of @huacnlee. This PR remains a draft for maintainer review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red Checks job on
main(first noticed from #3607): the v0.8.0 release notes credit@UncertaintyDeterminesYou4ndMeand@alex-vas, and the typos tokenizer reads those handles as the misspelled wordsndandvas— 15 findings, all inrelease-notes.md, reproduced with the pinnedtypos-cli 1.40.0on a pristine checkout.The fix is the narrowest one that meets the constraints from the #3607 review: the exact handle strings are added to
extend-ignore-re, sorelease-notes.mdis touched),release-notes.mditself is still checked — only the two handle matches are skipped,Verified locally with the pinned
typos-cli 1.40.0:typosexits 0 on the full repo with this change, and both recentChecksruns onmainfail exactly on these findings.