Skip to content

typos: Ignore the two release-notes contributor handles - #3608

Merged
huacnlee merged 1 commit into
longbridge:mainfrom
noosxe:typos-release-notes
Oct 20, 2026
Merged

huacnlee merged 1 commit into
longbridge:mainfrom
noosxe:typos-release-notes

Conversation

@noosxe

@noosxe noosxe commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Fixes the red Checks job on main (first noticed from #3607): the v0.8.0 release notes credit @UncertaintyDeterminesYou4ndMe and @alex-vas, and the typos tokenizer reads those handles as the misspelled words nd and vas — 15 findings, all in release-notes.md, reproduced with the pinned typos-cli 1.40.0 on a pristine checkout.

The fix is the narrowest one that meets the constraints from the #3607 review: the exact handle strings are added to extend-ignore-re, so

  • the handles stay verbatim (nothing in release-notes.md is touched),
  • release-notes.md itself is still checked — only the two handle matches are skipped,
  • no word-level or file-level disable that could mask a real typo elsewhere.

Verified locally with the pinned typos-cli 1.40.0: typos exits 0 on the full repo with this change, and both recent Checks runs on main fail exactly on these findings.

The v0.8.0 release notes left the Checks job red on main: the tokenizer
reads @UncertaintyDeterminesYou4ndMe as "nd" and @alex-vas as "vas".
Ignore the exact handle strings, so the handles stay verbatim and the
rest of release-notes.md (and the repo) remains fully checked.
@huacnlee
huacnlee merged commit 6c13c1f into longbridge:main Oct 20, 2026
18 checks passed
@noosxe
noosxe deleted the typos-release-notes branch October 20, 2026 21:32
huacnlee added a commit that referenced this pull request Oct 24, 2026
The valid Portuguese translations introduced by #3638 cause the pinned
typos 1.40.0 checker to report three false positives on main ([failing
Checks
job](https://github.com/longbridge/gpui-kit/actions/runs/39989920902/job/120538735238)).

Add three exact `pt-BR` expression exceptions, following #3608.
Translations remain unchanged; no global word exemption or file
exclusion is added.

Validation with the official typos-cli 1.40.0 release, verified against
its published SHA-256:
- Full repository before: exactly three findings, exit 2; after: exit 0.
- Negative controls still detect English `atual`, `Atual`, and
`seperate` in source, English locale entries, and the locale file
itself.
- Translation bytes unchanged; `git diff --check` passes.
- Independent review cleared the exact four-line patch. Rust tests were
not run for this configuration-only change.

Prepared with ChatGPT assistance on behalf of @huacnlee. This PR remains
a draft for maintainer review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants