feat(proto): add creation_size to ShardGroupExpandRequest#113
Draft
c3y1huang wants to merge 2 commits into
Draft
feat(proto): add creation_size to ShardGroupExpandRequest#113c3y1huang wants to merge 2 commits into
c3y1huang wants to merge 2 commits into
Conversation
c3y1huang
force-pushed
the
1061-v2-sharding-kbench-failure
branch
2 times, most recently
from
July 22, 2026 10:00
2d58d33 to
3d01351
Compare
longhorn/longhorn-1061 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
longhorn/longhorn-1061 Signed-off-by: Chin-Ya Huang <chin-ya.huang@suse.com>
c3y1huang
force-pushed
the
1061-v2-sharding-kbench-failure
branch
from
July 23, 2026 06:08
3d01351 to
5cbacb0
Compare
There was a problem hiding this comment.
Pull request overview
This PR extends the SPDK RPC protobuf for shard-group expansion to carry the shard group’s original creation-time volume size (creation_size), enabling callers (e.g., the engine/controller) to cap in-place expansion based on lvstore metadata sizing constraints.
Changes:
- Add
creation_sizetoShardGroupExpandRequestandShardGroupExpandPrecheckRequestinshardgroup.proto. - Regenerate Go protobuf bindings to include the new fields and accessors.
- Regenerate Python protobuf bindings to include the updated message descriptors.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| protobuf/spdkrpc/shardgroup.proto | Adds creation_size to expand and precheck request messages with explanatory comments. |
| pkg/generated/spdkrpc/shardgroup.pb.go | Regenerated Go protobuf output reflecting the new CreationSize fields and getters. |
| generated-py/spdkrpc/shardgroup_pb2.py | Regenerated Python protobuf output reflecting the new creation_size fields in descriptors. |
Files not reviewed (1)
- generated-py/spdkrpc/shardgroup_pb2.py: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#1061
What this PR does / why we need it:
See longhorn/go-spdk-helper#300 (comment).
Special notes for your reviewer:
NoneAdditional documentation or context
None