Lunatik states management for GSoC 2020 by MatheusNtg · Pull Request #20 · luainkernel/lunatik

MatheusNtg · 2020-08-17T15:30:41Z

No description provided.

lneto · 2020-09-03T20:50:53Z

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "deps/lua-memory"]
+	path = deps/lua-memory
+	url = https://github.com/MatheusNtg/lua-memory


it should refers to upstream, right? or do you have modifications in your fork?

I have modifications on my fork.

so, you need to make a PR as well.. what's the upstream repo? I think we should fork it on luainkernel and make a PR for it..

The upstream repo can be found here. I made a PR to lua-memory repo now

lneto · 2020-09-03T20:51:56Z

Makefile

@@ -1,4 +1,5 @@
-ccflags-y += -D_LUNATIK -D_KERNEL -I$(src) -D_CONFIG_FULL_PANIC
+ccflags-y += -D_LUNATIK -D_KERNEL -I$(src) -D_CONFIG_FULL_PANIC -DLUNATIK_UNUSED \
+							-I$(src)/lua -I$(src)/deps/lua-memory/src


Suggested change

-I$(src)/lua -I$(src)/deps/lua-memory/src

-I$(src)/lua -I$(src)/deps/lua-memory/src

please review and apply the same to the rest of the code..

lneto · 2020-09-03T20:52:58Z

Makefile

+	lua/lundump.o lua/lvm.o lua/lzio.o lua/lauxlib.o lua/lbaselib.o \
+	lua/lbitlib.o lua/lcorolib.o lua/ldblib.o lua/lstrlib.o \
+	lua/ltablib.o lua/lutf8lib.o lua/loslib.o lua/lmathlib.o lua/linit.o \
+	lua/loadlib.o luautil.o


why changing all these lines?

To put all lua related objects in on variable on the Lunatik building

you don't need change the indentation of this lines to do that.. please, take cara of that..

lneto · 2020-09-03T21:00:23Z

Makefile

+	lua/ltablib.o lua/lutf8lib.o lua/loslib.o lua/lmathlib.o lua/linit.o \
+	lua/loadlib.o luautil.o
+
+lua_memory-objs = deps/lua-memory/src/lmemlib.o deps/lua-memory/src/lmemmod.o


Suggested change

lua_memory-objs = deps/lua-memory/src/lmemlib.o deps/lua-memory/src/lmemmod.o

luamemory-path = deps/lua-memory/src

luamemory-objs = $(luamemory-path)/lmemlib.o $(luamemory-path)/lmemmod.o

lneto · 2020-09-03T21:04:28Z

lib/Makefile

@@ -0,0 +1,53 @@
+# Copyright (c) 2020 Matheus Rodrigues <matheussr61@gmail.com>


why are you copying this makefile if you have a submodule?

This is the makefile of lunatik user space module. What are you suggesting is to build the lunatik user space module from the submodule makefile?

lneto · 2020-09-03T21:13:49Z

lunatik_conf.h

+#ifndef LUNATIK_CONF_H
+#define LUNATIK_CONF_H
+
+#define LUNATIK_NAME_MAXSIZE 64     /* Max length of Lua state name  */


please, use the form:

#define <name>\t(<definition>)

and apply this to all your definitions..

states.c

lneto · 2020-09-06T23:19:39Z

lib/tests/list.lua

+assert(#states == 6)
+assert(#states2 == 6)
+
+


lneto · 2020-09-06T23:19:53Z

lib/tests/create.lua

+-- State created from another session
+ss2 = session2:newstate's1'
+assert(ss2 == nil)
+


…sion

…ion and rename state creation API

… 2020 commit)

…umentation and rename state creation API

… of session

NFLua Team and others added 4 commits June 23, 2020 14:36

Import states and luautil from NFLua

2775fba

Adapt NFLua states management to Lunatik

2b9aeb0

Operations per namespace implementation

c1c757b

Import luautil from NFLua

9623807

MatheusNtg requested review from VictorNogueiraRio, iru- and lneto August 17, 2020 15:30

MatheusNtg force-pushed the tests branch 2 times, most recently from 2f27696 to ca791dc Compare August 23, 2020 20:17

MatheusNtg force-pushed the tests branch 3 times, most recently from 87be836 to aad75a1 Compare August 27, 2020 19:48

lneto reviewed Sep 3, 2020

View reviewed changes

states.c Show resolved Hide resolved

MatheusNtg force-pushed the tests branch 4 times, most recently from a071917 to 8a8297a Compare September 4, 2020 14:27

lneto reviewed Sep 6, 2020

View reviewed changes

lib/tests/list.lua Outdated

assert(#states == 6)

assert(#states2 == 6)

Copy link
Copy Markdown

Contributor

lneto Sep 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/\n//

lneto reviewed Sep 6, 2020

View reviewed changes

lib/tests/create.lua

-- State created from another session

ss2 = session2:newstate's1'

assert(ss2 == nil)

Copy link
Copy Markdown

Contributor

lneto Sep 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/\n//

MatheusNtg force-pushed the tests branch 5 times, most recently from eeb6a66 to cb9b7c6 Compare September 11, 2020 16:52

MatheusNtg added 21 commits September 11, 2020 21:38

Add tests

9b86a2e

Add lua memory compilation from user lib

d2bebc6

Functions refatoration

a2f2841

Update documentation

694d9cc

Add lunatik_getenv function

5620872

Add support to get namespace from a given lunatik state

e863b1c

Change socket of states related operation to the state instead of ses…

4256e8d

…sion

Add function to get current memory usage of states, update documentat…

2987eca

…ion and rename state creation API

Update makefile to automatically remove unecessary objects (Last GSoC…

ea758c8

… 2020 commit)

fixup! Netlink implementation

b325f15

Update lua-memory submodule

103e61f

fixup! Change lua_Buffer to a normal buffer

5bffd2a

fixup! Add function to get current memory usage of states, update doc…

6302115

…umentation and rename state creation API

fixup! Adapt NFLua states management to Lunatik

de406cf

fixup! Add lua-memory as dependecy

cb6b769

fixup! Add tests

be94eca

fixup! Send data to kernel

8f8d8aa

fixup! Adapt control API from NFLua

d103135

fixup! Adapt messages sent to kernel

e335ddc

fixup! Change socket of states related operation to the state instead…

21f35ea

… of session

fixup! RABID-561 adjust Makefiles for generic compilation

6388358

MatheusNtg force-pushed the tests branch from 7a516b3 to 6388358 Compare September 11, 2020 21:39

Solved bug on module remotion

9277e14

MatheusNtg force-pushed the tests branch from 5d526dd to 70e4651 Compare October 17, 2020 18:27

Implementation of put state function

e9663d3

MatheusNtg force-pushed the tests branch from 70e4651 to e9663d3 Compare October 30, 2020 18:15

lneto force-pushed the master branch 2 times, most recently from 08920ce to 33e4e42 Compare February 10, 2025 22:17

lneto force-pushed the master branch 2 times, most recently from 17ac113 to 925bfd9 Compare July 14, 2025 01:10

	-I$(src)/lua -I$(src)/deps/lua-memory/src
	-I$(src)/lua -I$(src)/deps/lua-memory/src

	lua_memory-objs = deps/lua-memory/src/lmemlib.o deps/lua-memory/src/lmemmod.o
	luamemory-path = deps/lua-memory/src
	luamemory-objs = $(luamemory-path)/lmemlib.o $(luamemory-path)/lmemmod.o

		@@ -0,0 +1,53 @@
		# Copyright (c) 2020 Matheus Rodrigues <matheussr61@gmail.com>

Conversation

MatheusNtg commented Aug 17, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lneto Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lneto Sep 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lneto Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

lneto Sep 3, 2020 •

edited

Loading

lneto Sep 4, 2020 •

edited

Loading

lneto Sep 3, 2020 •

edited

Loading