Skip to content

Fix reload after rebuilds of the target extension #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jwoertink merged 1 commit into from
Apr 20, 2026
Merged

Fix reload after rebuilds of the target extension #2038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions src/bun/lucky.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,11 @@ export default {
},

async watch() {
const cssBase = ['css']
const jsBase = ['js', 'ts', 'jsx', 'tsx']
const extras = this.config.watchExtensions || {}
const cssExts = ['css', ...(extras.css || [])]
const jsExts = ['js', 'ts', 'jsx', 'tsx', ...(extras.js || [])]
const cssExts = [...cssBase, ...(extras.css || [])]
const jsExts = [...jsBase, ...(extras.js || [])]

const handler = (event, filename) => {
if (!filename) return
Expand Down Expand Up @@ -306,12 +308,20 @@ export default {
console.log(` ▸ ${normalizedFilename} changed`)
;(async () => {
try {
if (cssExts.includes(ext)) await this.buildCSS()
else if (jsExts.includes(ext)) await this.buildJS()
else if (base.includes('.')) await this.copyStaticAssets()
let kind = null
if (cssExts.includes(ext)) {
await this.buildCSS()
if (cssBase.includes(ext)) kind = 'css'
} else if (jsExts.includes(ext)) {
await this.buildJS()
if (jsBase.includes(ext)) kind = 'full'
} else if (base.includes('.')) {
await this.copyStaticAssets()
kind = 'full'
}

await this.writeManifest()
this.reload(ext === 'css' ? 'css' : 'full')
if (kind) this.reload(kind)
} catch (err) {
console.error(' ✖ Build error:', err.message)
if (err.errors) for (const e of err.errors) console.error(e)
Expand Down