refactor: qrm allocation hooks - #6
Open
luomingmeng wants to merge 5 commits into
Open
Conversation
luomingmeng
changed the title
luomingmeng
force-pushed
the
feat/qrm-cpu-numa-rp-optimization
branch
from
May 16, 2026 03:29
4bd5500 to
b9f496a
Compare
luomingmeng
force-pushed
the
refactor/qrm-allocation-hooks
branch
from
May 16, 2026 03:30
5518efd to
f8b2d29
Compare
luomingmeng
force-pushed
the
feat/qrm-cpu-numa-rp-optimization
branch
from
May 17, 2026 09:15
b9f496a to
648d437
Compare
luomingmeng
force-pushed
the
refactor/qrm-allocation-hooks
branch
from
May 17, 2026 09:16
f8b2d29 to
5b1efc7
Compare
luomingmeng
force-pushed
the
feat/qrm-cpu-numa-rp-optimization
branch
from
May 20, 2026 07:36
648d437 to
2364f22
Compare
xu282934741
approved these changes
May 25, 2026
xu282934741
approved these changes
May 25, 2026
luomingmeng
force-pushed
the
feat/qrm-cpu-numa-rp-optimization
branch
from
May 27, 2026 09:18
2364f22 to
8902882
Compare
luomingmeng
force-pushed
the
refactor/qrm-allocation-hooks
branch
from
May 27, 2026 09:58
5b1efc7 to
bb15966
Compare
luomingmeng
force-pushed
the
feat/qrm-cpu-numa-rp-optimization
branch
from
May 29, 2026 14:47
8902882 to
f9a392b
Compare
luomingmeng
force-pushed
the
refactor/qrm-allocation-hooks
branch
from
May 29, 2026 14:49
bb15966 to
ee8d9f9
Compare
luomingmeng
force-pushed
the
feat/qrm-cpu-numa-rp-optimization
branch
2 times, most recently
from
June 3, 2026 05:40
874dc7a to
0cd2f66
Compare
luomingmeng
force-pushed
the
refactor/qrm-allocation-hooks
branch
2 times, most recently
from
June 3, 2026 06:30
86fe96c to
8b4290e
Compare
…rp-optimization feat: qrm cpu numa rp optimization
- Add pre-update validation hooks for CPU allocation. - Modify updateAllocationInfo to accept old allocation info so hooks can observe the prior state.
…configuration - Add ExportedAllocationInfoAnnotationKeys field to GenericQRMPluginOptions and GenericQRMPluginConfiguration to support filtering annotations in allocation responses. - Rename IsInMemoryStore to EnableInMemoryState in GenericQRMPluginConfiguration to align with naming conventions and clarify its purpose. - Update NewGenericQRMPluginOptions and ApplyTo methods to handle the new configuration field.
… annotations - Add GetPodAggregatedRequestResourceByAnnotations to provide flexible resource request extraction from pod annotations with fallback support. - Add GetExportedAllocationInfoAnnotationKeys and GetExportedAnnotations to filter and extract specific annotations from AllocationInfo for ResourceAllocationResponse. - Refactor GetPodAggregatedRequestResource to utilize the new annotation-based extraction logic. - Add comprehensive unit tests for the new utility functions in util_test.go.
- Integrate allocation hooks in CPU DynamicPolicy, updating PackAllocationResponse and GetCPUTopologyAllocationsAnnotations. - Integrate allocation hooks in Memory DynamicPolicy, introducing getPackAllocationResponse. - Fix potential deadlock issues by removing redundant locks. - Add memory-specific annotation helpers and update unit tests.
luomingmeng
force-pushed
the
refactor/qrm-allocation-hooks
branch
from
June 3, 2026 06:46
8b4290e to
071ab58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Features/Refactor/Bug fixes
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: