feat: add NaturalUnicodeDelimitedTupleAttribute#58
Open
ryancausey wants to merge 1 commit intolyft:masterfrom
Open
feat: add NaturalUnicodeDelimitedTupleAttribute#58ryancausey wants to merge 1 commit intolyft:masterfrom
ryancausey wants to merge 1 commit intolyft:masterfrom
Conversation
This adds a new field, NaturalUnicodeDelimitedTupleAttribute that extends UnicodeDelimitedTupleAttribute with datetime object handling and also implements zero padding of integers and floats. The motivation was the need for natural sort order of composite sort keys that contain a number element within the key. The default lexicographical sorting would put 10 before 2 when these numbers are serialized and stored in DynamoDB as strings. By adding leading 0s to pad the numbers when they are serialized to strings, we can force a natural sort order where "02" sorts before "10". This also adds logic to store any datetime objects encountered in a ISO8601 formatted string to take advantage of that format's lexicographical sorting properties. This was done to also allow proper sorting of a composite key based on datetime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new field, NaturalUnicodeDelimitedTupleAttribute that extends UnicodeDelimitedTupleAttribute with datetime object handling and also implements zero padding of integers and floats. The motivation was the need for natural sort order of composite sort keys that contain a number element within the key. The default lexicographical sorting would put 10 before 2 when these numbers are serialized and stored in DynamoDB as strings. By adding leading 0s to pad the numbers when they are serialized to strings, we can force a natural sort order where "02" sorts before "10". This also adds logic to store any datetime objects encountered in a ISO8601 formatted string to take advantage of that format's lexicographical sorting properties. This was done to also allow proper sorting of a composite key based on datetime.
Closes #57