Throw exception when stating a non-existent directory#32
Open
eltouf wants to merge 1 commit intom2mtech:mainfrom
Open
Throw exception when stating a non-existent directory#32eltouf wants to merge 1 commit intom2mtech:mainfrom
eltouf wants to merge 1 commit intom2mtech:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where
StreamStatCommand::runreturns a stat array instead of throwing an exception when targeting a directory that does not exist.Context & Problem
league/flysystem-aws-s3-v3(3.32.0)Since commit b5c83a6, the generic PHP function
is_dirappears to returntrueeven when a folder does not exist in the source wrapper.Technical Analysis
Before the mentioned commit, the following line ensured an exception was thrown if the file/directory was missing:
However, with the changes introduced, this check is bypassed or no longer triggers the exception for non-existent directories. Consequently, StreamStatCommand returns a success array for paths that are technically invalid/missing.
Expected Behavior
StreamStatCommand::run should throw a League\Flysystem\UnableToRetrieveMetadata (or similar) exception when attempting to retrieve stats for a non-existent directory, restoring the behavior prior to v1.4.x changes.