Skip to content

https://github.com/mP1/walkingkooka-spreadsheet/pull/10355 HasSpreads… #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mP1 merged 1 commit into from
Oct 10, 2026
Merged

https://github.com/mP1/walkingkooka-spreadsheet/pull/10355 HasSpreads… #971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...java/walkingkooka/spreadsheet/expression/function/SpreadsheetExpressionFunctionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5326,7 +5326,7 @@ public void testEvaluateWriteStorage() {
null, // expected value
"" // printed
).spreadsheetExpressionEvaluationContext(
SpreadsheetExpressionEvaluationContext.NO_CELL,
SpreadsheetExpressionEvaluationContext.NO_SPREADSHEET_CELL,
SpreadsheetExpressionReferenceLoaders.empty()
);

Expand All @@ -5353,7 +5353,7 @@ public void testEvaluateWriteStorageText() {
null, // expected value
"" // printed
).spreadsheetExpressionEvaluationContext(
SpreadsheetExpressionEvaluationContext.NO_CELL,
SpreadsheetExpressionEvaluationContext.NO_SPREADSHEET_CELL,
SpreadsheetExpressionReferenceLoaders.empty()
);

Expand Down Expand Up @@ -5656,7 +5656,7 @@ public SpreadsheetStoreRepository storeRepository() {
// only SCRIPTING allows updatable EnvironmentContext
final SpreadsheetExpressionEvaluationContext spreadsheetExpressionEvaluationContext = spreadsheetEngineContext.setSpreadsheetMetadataMode(SpreadsheetMetadataMode.SCRIPTING)
.spreadsheetExpressionEvaluationContext(
SpreadsheetExpressionEvaluationContext.NO_CELL, // no cell
SpreadsheetExpressionEvaluationContext.NO_SPREADSHEET_CELL, // no cell
SpreadsheetExpressionReferenceLoaders.spreadsheetStoreRepository(
spreadsheetEngineContext.storeRepository()
)
Expand Down Expand Up @@ -5704,7 +5704,7 @@ public SpreadsheetStoreRepository storeRepository() {
final Object value = spreadsheetExpressionEvaluationContext.evaluateExpression(
spreadsheetEngineContext.parseFormula(
TextCursors.charSequence(formula),
SpreadsheetExpressionEvaluationContext.NO_CELL
SpreadsheetExpressionEvaluationContext.NO_SPREADSHEET_CELL
).toExpression(spreadsheetExpressionEvaluationContext)
.orElseThrow(() -> new IllegalStateException("Unable to make Expression"))
);
Expand Down
Loading