Web OIDC: send PKCE S256 so PKCE-enforcing IdPs work - #944
Open
stevenolen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #928
The web login flow never sent PKCE params, so IdPs that enforce PKCE rejected it. This generates a code verifier + S256 challenge on the client and sends code_challenge/code_challenge_method=S256 on the auth request. Backend was already PKCE-ready (stores the verifier, replays it in token exchange), so this is client-side only.
Tested locally against my live deployment: OIDC login now succeeds against a PKCE-enforcing IdP. Added tests for the S256 challenge (RFC 7636 vector + output shape) as well.