Skip to content

Fix container image and resync package lock files#1544

Merged
SamErde merged 7 commits intomainfrom
package-lock
Mar 29, 2026
Merged

Fix container image and resync package lock files#1544
SamErde merged 7 commits intomainfrom
package-lock

Conversation

@SamErde
Copy link
Copy Markdown
Contributor

@SamErde SamErde commented Mar 29, 2026

Description

This pull request updates the development container and several dependencies to use newer versions, primarily focusing on updating the Node.js base image and synchronizing related type definitions and packages. There are also some minor adjustments to package metadata, especially around peer dependency flags in the lockfile.

Development environment updates:

  • Updated the dev container base image in .devcontainer/devcontainer.json from javascript-node:1-24-bookworm to javascript-node:24-trixie for a more recent Node.js and OS stack.

Dependency and type updates:

  • Upgraded @types/node from version 22.x to 24.x in both package-lock.json and the dev dependencies, aligning type definitions with the new Node.js version. [1] [2]
  • Updated the dependency on undici-types to a newer version compatible with Node.js 24.

Package-lock metadata adjustments:

These changes ensure the development environment and dependencies are up to date and better aligned with the latest Node.js ecosystem, improving compatibility and maintainability.

Contribution Checklist

Before submitting this PR, please confirm you have completed the following:

  • 📖 Read the guidelines for contributing to this repository.
  • 🧪 Ensure the build and unit tests pass by running /powershell/tests/pester.ps1 on your local system.

@SamErde SamErde requested review from a team as code owners March 29, 2026 11:21
Copilot AI review requested due to automatic review settings March 29, 2026 11:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the development environment to Node.js 24 and resynchronizes npm lockfiles, including workarounds for upstream packages that fail under Node.js v24 module resolution.

Changes:

  • Updated devcontainer image to a newer Node.js 24 + distro base.
  • Added a postinstall patch script in website/ to fix a missing CJS entrypoint in combine-promises.
  • Pinned cacheable-request via overrides and refreshed package-lock.json metadata (including updated @types/node / undici-types in lockfiles).

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.devcontainer/devcontainer.json Switches the devcontainer base image to a newer Node.js 24 image/distro tag.
website/scripts/patch-combine-promises.js Adds a postinstall workaround that writes a missing dist/index.js for combine-promises.
website/package.json Registers the postinstall script and pins cacheable-request via npm overrides.
website/package-lock.json Lockfile resync reflecting overrides and updated dependency metadata.
report/package-lock.json Lockfile resync including @types/node/undici-types updates and peer metadata adjustments.
Files not reviewed (2)
  • report/package-lock.json: Language not supported
  • website/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Removed postinstall script from package.json
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Mar 29, 2026

Deploying maester with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5d94eb7
Status: ✅  Deploy successful!
Preview URL: https://95cda397.maester.pages.dev
Branch Preview URL: https://package-lock.maester.pages.dev

View logs

@SamErde SamErde merged commit c4363f2 into main Mar 29, 2026
9 checks passed
@SamErde SamErde deleted the package-lock branch March 29, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants