Fix container image and resync package lock files#1544
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the development environment to Node.js 24 and resynchronizes npm lockfiles, including workarounds for upstream packages that fail under Node.js v24 module resolution.
Changes:
- Updated devcontainer image to a newer Node.js 24 + distro base.
- Added a
postinstallpatch script inwebsite/to fix a missing CJS entrypoint incombine-promises. - Pinned
cacheable-requestviaoverridesand refreshedpackage-lock.jsonmetadata (including updated@types/node/undici-typesin lockfiles).
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.devcontainer/devcontainer.json |
Switches the devcontainer base image to a newer Node.js 24 image/distro tag. |
website/scripts/patch-combine-promises.js |
Adds a postinstall workaround that writes a missing dist/index.js for combine-promises. |
website/package.json |
Registers the postinstall script and pins cacheable-request via npm overrides. |
website/package-lock.json |
Lockfile resync reflecting overrides and updated dependency metadata. |
report/package-lock.json |
Lockfile resync including @types/node/undici-types updates and peer metadata adjustments. |
Files not reviewed (2)
- report/package-lock.json: Language not supported
- website/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Removed postinstall script from package.json
Deploying maester with
|
| Latest commit: |
5d94eb7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://95cda397.maester.pages.dev |
| Branch Preview URL: | https://package-lock.maester.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the development container and several dependencies to use newer versions, primarily focusing on updating the Node.js base image and synchronizing related type definitions and packages. There are also some minor adjustments to package metadata, especially around peer dependency flags in the lockfile.
Development environment updates:
.devcontainer/devcontainer.jsonfromjavascript-node:1-24-bookwormtojavascript-node:24-trixiefor a more recent Node.js and OS stack.Dependency and type updates:
@types/nodefrom version22.xto24.xin bothpackage-lock.jsonand the dev dependencies, aligning type definitions with the new Node.js version. [1] [2]undici-typesto a newer version compatible with Node.js 24.Package-lock metadata adjustments:
@emnapi/coreand@emnapi/runtimeas optional and peer dependencies inpackage-lock.json.@rollup/rollup-*platform-specific packages and others), explicitly set thepeerflag totrueor removed it where unnecessary, cleaning up peer dependency metadata. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27] [28] [29] [30] [31] [32] [33] [34] [35] [36]These changes ensure the development environment and dependencies are up to date and better aligned with the latest Node.js ecosystem, improving compatibility and maintainability.
Contribution Checklist
Before submitting this PR, please confirm you have completed the following:
/powershell/tests/pester.ps1on your local system.