Fix visibility filter type mismatch and harden feed attribute handling#286
Open
Marvin-Magmodules wants to merge 2 commits into
Open
Fix visibility filter type mismatch and harden feed attribute handling#286Marvin-Magmodules wants to merge 2 commits into
Marvin-Magmodules wants to merge 2 commits into
Conversation
- Cast visibility filter values to int for strict in_array on PHP 8.x - Guard Item::add() against missing row id - Preserve hardcoded attributes (id, title, price) when EAV lookup fails instead of unsetting them, preventing "Undefined array key" crashes
Covers basic feed generation, required fields validation, visibility filter with type mismatch regression, token auth, module disabled state, and single product feed. Fixes feed tests to use process.env.CHANNABLE_TOKEN instead of hardcoding token into Magento config.
Marvin-Magmodules
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
in_arraycomparison, fixing type mismatch between string config values and intgetVisibility()Item::add()against missing row idTest plan