loader: handle SegmentationViolation for malformed ELF files #2799

kami922 · 2025-12-23T16:05:59Z

When processing malformed ELF files with invalid relocations, vivisect raises envi.exc.SegmentationViolation during relocation processing. This change catches these exceptions and converts them to CorruptFile exceptions with helpful error messages instead of crashing with a traceback.

Summary

When processing malformed ELF files with invalid relocations, vivisect raises envi.exc.SegmentationViolation during relocation processing. This PR catches these exceptions and converts them to CorruptFile exceptions with helpful error messages instead of crashing with a traceback.

Changes

Added exception handling for envi.exc.SegmentationViolation in get_workspace()
Converts low-level vivisect errors to user-friendly CorruptFile exception
Updated CHANGELOG.md

When processing malformed ELF files with invalid relocations, vivisect raises envi.exc.SegmentationViolation during relocation processing. This change catches these exceptions and converts them to CorruptFile exceptions with helpful error messages instead of crashing with a traceback. Fixes mandiant#2794

gemini-code-assist · 2025-12-23T16:06:12Z

Summary of Changes

Hello @kami922, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the loader's resilience by introducing specific exception handling for vivisect's SegmentationViolation errors. This change ensures that when processing malformed ELF files, the application gracefully handles invalid memory references, providing clear CorruptFile exceptions instead of crashing, thereby improving the overall stability and user experience.

Highlights

Robust Error Handling: Implemented robust error handling for malformed ELF files that cause envi.exc.SegmentationViolation during relocation processing.
User-Friendly Exceptions: Converted low-level vivisect SegmentationViolation exceptions into more user-friendly CorruptFile exceptions with informative error messages, preventing application crashes.
Changelog Update: Updated the CHANGELOG.md to reflect the fix for gracefully handling malformed ELF files.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request effectively addresses a crash when processing malformed ELF files by introducing specific exception handling for envi.exc.SegmentationViolation. The change correctly catches this low-level error and raises a more user-friendly CorruptFile exception, improving the tool's robustness and error reporting. The implementation is clean, follows best practices by chaining exceptions, and includes a corresponding update to the changelog. This is a great improvement.

mike-hunhoff

Thank you @kami922. Please see my review and address the requested changes.

mike-hunhoff · 2025-12-29T16:50:26Z

CHANGELOG.md


 ### Bug Fixes

+- loader: gracefully handle malformed ELF files with invalid relocations @kami922 #2794


Please move this to the unreleased section of the CHANGELOG and replace the issue number with the number of this PR.

mike-hunhoff · 2025-12-29T16:52:15Z

capa/loader.py

 from typing import Optional
 from pathlib import Path

+import envi.exc


Please move this to

capa/capa/loader.py

Lines 158 to 160 in 546a672

# lazy import enables us to not require viv if user wants another backend.

import viv_utils

import viv_utils.flirt

mike-hunhoff · 2025-12-29T16:53:28Z

capa/loader.py

        else:
            raise ValueError("unexpected format: " + input_format)
+    except envi.exc.SegmentationViolation as e:
+        # Malformed binary with invalid memory references (e.g., broken ELF relocations)


Nice comment!

@mike-hunhoff

- Move import envi.exc to align with viv_utils lazy imports - Update CHANGELOG to reference PR mandiant#2799 instead of issue mandiant#2794 Addresses feedback from @mike-hunhoff

gemini-code-assist bot reviewed Dec 23, 2025

View reviewed changes

mike-hunhoff requested changes Dec 29, 2025

View reviewed changes

loader: address review feedback for PR mandiant#2799

7133762

- Move import envi.exc to align with viv_utils lazy imports - Update CHANGELOG to reference PR mandiant#2799 instead of issue mandiant#2794 Addresses feedback from @mike-hunhoff

kami922 force-pushed the fix-2794-segfault branch from 546a672 to 7133762 Compare December 29, 2025 21:25

Merge branch 'master' into fix-2794-segfault

bdc2a80

kami922 requested a review from mike-hunhoff January 2, 2026 14:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

loader: handle SegmentationViolation for malformed ELF files #2799

loader: handle SegmentationViolation for malformed ELF files #2799

Uh oh!

kami922 commented Dec 23, 2025

Uh oh!

gemini-code-assist bot commented Dec 23, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

mike-hunhoff left a comment

Uh oh!

mike-hunhoff Dec 29, 2025

Uh oh!

mike-hunhoff Dec 29, 2025

Uh oh!

mike-hunhoff Dec 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		### Bug Fixes

		- loader: gracefully handle malformed ELF files with invalid relocations @kami922 #2794

	# lazy import enables us to not require viv if user wants another backend.
	import viv_utils
	import viv_utils.flirt

loader: handle SegmentationViolation for malformed ELF files #2799

Are you sure you want to change the base?

loader: handle SegmentationViolation for malformed ELF files #2799

Uh oh!

Conversation

kami922 commented Dec 23, 2025

Summary

Changes

Uh oh!

gemini-code-assist bot commented Dec 23, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

mike-hunhoff left a comment

Choose a reason for hiding this comment

Uh oh!

mike-hunhoff Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

mike-hunhoff Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

mike-hunhoff Dec 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants