Repository navigation
Conversation
Signed-off-by: Kenneth Mitchell <kmitchel46725@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
GET and POST
/Items/{itemId}/PlaybackInfonow accept a recording ID returned by/LiveTv/Recordings. A client can negotiate playback using the DVR ID even before the recording has a scanned library item.Upgrade note: None.
Why
Ferrofin stores recordings separately from library items. The recording stream routes already resolve DVR IDs, but PlaybackInfo returned 404 at the library lookup before it asked the media source manager. Jellyfin v12.4 uses library item IDs for recordings. See MediaInfoController and LiveTvController.
How
Keep the existing library lookup first. For a DVR ID, share the streaming routes' Live TV and recording visibility checks, then use the existing DVR source lookup by ID. Hidden library items remain hidden, and unrelated IDs still return 404. The access-filtering parity record describes the DVR ID fallback.
The change touches the API playback and stream authorization paths. Successful library lookups avoid the DVR fallback. Routes and storage schema are unchanged.
Verification
Checklist
cargo fmt --all --check.