Open
Conversation
marianogappa
approved these changes
Jul 22, 2021
Owner
marianogappa
left a comment
marianogappa
left a comment
There was a problem hiding this comment.
Hey! Thanks for contributing! 👍 How about keeping the camelCase for the JSON? I added suggestions for how to do it in the struct, but will require changes on the example. Otherwise do merge it.
| const DefaultMaxAppServerConnections = 5 | ||
|
|
||
| type settings struct { | ||
| MaxAppServerConnections int64 |
Owner
There was a problem hiding this comment.
Suggested change
| MaxAppServerConnections int64 | |
| MaxAppServerConnections int64 `json:"maxAppServerConnections"` |
|
|
||
| type settings struct { | ||
| MaxAppServerConnections int64 | ||
| Databases map[string]database |
Owner
There was a problem hiding this comment.
Suggested change
| Databases map[string]database | |
| Databases map[string]database `json:"databases"` |
| type settings struct { | ||
| MaxAppServerConnections int64 | ||
| Databases map[string]database | ||
| DatabaseGroups map[string][]string |
Owner
There was a problem hiding this comment.
Suggested change
| DatabaseGroups map[string][]string | |
| DatabaseGroups map[string][]string `json:"databaseGroups"` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main feature: configure groups of databases, include/exclude groups of database. See updated README for usage.
Other changes: