Open
Conversation
This was referenced Nov 1, 2022
InfiniteSwerve
force-pushed
the
crypto-test-hold-8
branch
from
872fe86 to
05f22da
Compare
InfiniteSwerve
force-pushed
the
crypto-test-hold-9
branch
from
4a29562 to
857451f
Compare
InfiniteSwerve
force-pushed
the
crypto-test-hold-8
branch
from
05f22da to
8b38ac7
Compare
InfiniteSwerve
force-pushed
the
crypto-test-hold-9
branch
from
857451f to
324788d
Compare
InfiniteSwerve
force-pushed
the
crypto-test-hold-8
branch
from
8b38ac7 to
38e6cb8
Compare
InfiniteSwerve
force-pushed
the
crypto-test-hold-9
branch
from
324788d to
b4a41eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends
Do not merge unless target is main
Problem
We want to make sure that the signatures generated by tezos-crypto and deku-crypto match
Solution
Adds test converting lists of signatures to a large string, and checking their equality.
note: This test currently fails. This is ok for now, and will be fixed once other tests have been added.