Skip cells marked disabled when building the execute-cells request (#154)

[lazizbekravshanov]

Why

Cells authored as @app.cell(disabled=True) are executed by the VS Code extension, even though marimo's own frontend respects the flag. @manzt confirmed in #154 that disabled cells "aren't currently supported" in the extension and welcomed a contribution.

Root cause: extension/src/lib/extractExecuteCodeRequest.ts assembles the execute-cells request for both execution paths (NotebookControllerFactory and SandboxController), but its loop only skips cells without a stable id — it never consults the disabled config. The flag does survive the pipeline (marimo file → LSP deserialize → NotebookSerializer → cell metadata.options.disabled); I confirmed the wire format by running the server's own deserialize path, where a disabled cell arrives as options: { "disabled": true }.

What

• Add an isDisabled getter on MarimoNotebookCell (metadata.options?.disabled === true), mirroring the existing isStale getter. No schema change — CellMetadata already types options as Record<string, unknown>.
• Skip disabled cells in extractExecuteCodeRequest, fixing both call sites at the single choke point (rather than per-call-site, which would let a future call site silently reintroduce the bug).
• Fix a latent bug the filter exposes: the if (codes.length === 0) branch called Option.none() without returning, so a selection of only-disabled cells would have sent an empty execute-cells request. It now returns Option.none(), which the controller already handles by stopping ("Empty execution request").

Evidence

extension/src/lib/__tests__/extractExecuteCodeRequest.test.ts (4 tests):

• excludes cells disabled via @app.cell(disabled=True) (issue #154) — fails before (expected [...'cell-disabled'] to not include 'cell-disabled'), passes after.
• returns none when every selected cell is disabled — covers the empty-request branch.
• 2 sanity cases (enabled cells included; id-less cells skipped).

Full just test-ts green (466 passed / 1 skipped, +4 from this PR), just lint (ruff + ty + TS) clean, just test-vscode integration suite green.

Manual (F5): in the Extension Development Host, a notebook with a normal cell and a @app.cell(disabled=True) cell, run all → the disabled cell produces no output while the enabled cell runs. Matches marimo's own frontend.

Issues

Closes #154.

Open question

Enforce at the extension layer (where the request is assembled, as here) or the LSP server layer? I chose the extension layer since that's where the request is built and this was framed as a missing extension feature — happy to move it if you'd prefer the server side.

Checklist

• Unit tests added (regression + empty-request edge case)
• just test-ts and just lint pass locally
• just test-vscode integration suite passes
• Manual end-to-end (F5) verified

[github-actions]

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

[lazizbekravshanov]

Hi @manzt — opening this for #154 (disabled cells executing in the extension) as a first contribution. I traced it to extractExecuteCodeRequest, where the request loop never checked the disabled config; the fix skips disabled cells at that single choke point and adds a regression test, plus a fix for a latent empty-request branch it exposed.

One open question in the description: would you prefer this enforced at the extension layer (where I put it) or the LSP server layer? I didn't find a PR template or a PR-format note in CONTRIBUTING.md — happy to follow any convention you'd like. Thanks for taking a look!

[manzt]

Sorry, I've been out on jury duty. I think this fix looks great.

In a follow up, we probably want some to reflect the disabled nature of the cells in the UI (and allow for enabling/disabling) but that can be a follow up.