Repository navigation
fix!: migrate pan gesture to Gesture Handler 3 - #3
Merged
Merged
Conversation
BREAKING CHANGE: react-native-gesture-handler 3 or newer is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gesture.Pan()builder with Gesture Handler 3'susePanGesturehook.onBeginandonUpdatedirectly and mappingonEndtoonDeactivate.useCallbackand resolve the existing effect-dependency lint errors.Why
Gesture Handler 3 routes builder gestures through its legacy detector bridge. In a Reanimated UI runtime that bridge can serialize an undefined state-manager module namespace and crash with:
Using the v3 hook API avoids that legacy path entirely.
Fixes #2.
Breaking change
react-native-gesture-handler3 or newer is now required. Gesture Handler 2 consumers should remain onreact-native-snap-area@0.1.x, so this should be released as a compatibility-breaking version.Verification
yarn install --cwd example --frozen-lockfileyarn install --frozen-lockfileyarn lint(passes with existing inline-style warnings)yarn typecheckyarn test --runInBandyarn prepacknpm pack --dry-runusePanGestureand contain noGesture.Pan()call.