Add support for marshmallow.fields.Number.as_string#805
Open
rockTA wants to merge 1 commit intomarshmallow-code:devfrom
Open
Add support for marshmallow.fields.Number.as_string#805rockTA wants to merge 1 commit intomarshmallow-code:devfrom
rockTA wants to merge 1 commit intomarshmallow-code:devfrom
Conversation
ba74d7b to
904b343
Compare
Author
|
Push :) |
lafrech
requested changes
Mar 6, 2023
Member
lafrech
left a comment
There was a problem hiding this comment.
Thanks for contributing and sorry about the delay.
I think it would be nicer if we added a number2properties method overriding the output of field2type_and_format.
|
This PR is also missing also adding format as decimal when using number as_string. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some applications serialize decimal numbers as strings, as binary representation of floats can't be precise. However, when the OpenAPI documentation is created, this is currently not being taken into account if the
Decimaltype is used with theas_stringoption. With this change the documentation accurately represents what is being returned.