This repository was archived by the owner on Jun 6, 2024. It is now read-only.
Resource identifier objects, override top level links.#64
Open
RazerM wants to merge 4 commits intomarshmallow-code:devfrom
Open
Resource identifier objects, override top level links.#64RazerM wants to merge 4 commits intomarshmallow-code:devfrom
RazerM wants to merge 4 commits intomarshmallow-code:devfrom
Conversation
Contributor
Author
|
Would this be merged if I added documentation, or does this not fit your API? |
Contributor
Author
|
bump? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still needs documentation, do not merge.
This PR adds a
resource_identifierkeyword argument toSchemato dump resource identifier objects, as you would at a relationships endpoint, e.g./users/<user_id>/relationships/articles.In cases like this, both
selfandrelatedURLs are different from theArticleSchemawe'd use to dump the data.The Flask extension uses views:
The logic for this was put into
get_top_level_links, like was done when theself_urlandself_url_manyoptions were added.