Skip to content

lexers: update for later RouterOS releases#1337

Open
eworm-de wants to merge 1 commit intomartanne:masterfrom
eworm-de:lexers-routeros
Open

lexers: update for later RouterOS releases#1337
eworm-de wants to merge 1 commit intomartanne:masterfrom
eworm-de:lexers-routeros

Conversation

@eworm-de
Copy link
Copy Markdown
Collaborator

No description provided.

@fischerling
Copy link
Copy Markdown
Collaborator

Did we reach a conses how to handle lexer updates?

I know that Matej did favor pulling all changes from Scintillua at once.

@rnpnr Should we merge individual lexer changes?

@eworm-de
Copy link
Copy Markdown
Collaborator Author

What ever you like... I can send it there if you prefer.

@fischerling
Copy link
Copy Markdown
Collaborator

What ever you like... I can send it there if you prefer.

If you did not sent the patches upstream, then yes please create a pull request at https://github.com/orbitalquark/scintillua.

@eworm-de
Copy link
Copy Markdown
Collaborator Author

Opened orbitalquark/scintillua#200 ...

Do you want to close this now?

@fischerling
Copy link
Copy Markdown
Collaborator

Do you want to close this now?

I think we should wait for consensus on how we handle our downstream lexer code.

@rnpnr
Copy link
Copy Markdown
Collaborator

rnpnr commented Apr 24, 2026

@rnpnr Should we merge individual lexer changes?

I think we want to avoid it and instead just bulk update whenever there is a new scintillua release. Its easier to manage that way (also if we squash all the scintillua changes into a single commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants