Skip to content

Change app role to 'Editor' in URL Types - #6

Open
pr1mal wants to merge 5 commits into
martinfinke:masterfrom
pr1mal:master
Open

pr1mal wants to merge 5 commits into
martinfinke:masterfrom
pr1mal:master

Conversation

@pr1mal

@pr1mal pr1mal commented Feb 5, 2020

Copy link
Copy Markdown

This is potential fix for No return value #4.

With this fix in place, I'm able to make Bear.app to respond using x-success.

Changes that actually address the issue are in AppDelegate.m, the rest changes I made to be able to build project with latest XCode, so they might be unnecessary.

@pr1mal
pr1mal requested a review from martinfinke February 5, 2020 09:06
@pr1mal pr1mal mentioned this pull request Feb 5, 2020
These changes do not address issue of Bear not calling back
to xcall. Thanks to u/trix180 for helping me understand that :)
Fix for issue martinfinke#4. Reason is that MacOS was not always able to identify
particular xcall.app instance as 'xcall066958CA' protocol owner which
caused sometimes inability to get x-success/x-error responses

Project preferences changes in URL Types section:
- Role changed from 'Viewer' to 'Editor' to allow xcall.app to be identified
  by MacOS as protocol owner
- Added identifier of original xcall.app developer - Martin Finke
@pr1mal pr1mal closed this Feb 6, 2020
@pr1mal pr1mal reopened this Feb 6, 2020
@pr1mal

pr1mal commented Feb 6, 2020

Copy link
Copy Markdown
Author

Finally I was able to fix the problem for me and I believe for others who experienced it too.

Reason was that MacOS was not always able to identify particular xcall.app instance as an owner of 'xcall066958CA' protocol which caused sometimes inability to get x-success/x-error responses - they were just routed somewhere else by OS. Changing app's role from URL Scheme 'viewer' to URL Scheme 'Editor' made it work for me consistently.

Project preferences changes in URL Types section:

  • Role changed from 'Viewer' to 'Editor' to allow xcall.app to be identified by MacOS as protocol owner
  • Added identifier of original xcall.app developer - Martin Finke

@pr1mal pr1mal changed the title URL-encode x-success/x-error callbacks Change app role to 'Editor' in URL Types Feb 6, 2020
@fabianmu

Copy link
Copy Markdown

I am having the same issue with Bear.app and would like to use your PR'd Version.
@pr1mal Do you happen to have a binary as I'm not familiar how to compile this myself :/

@fabianmu

Copy link
Copy Markdown

nevermind @pr1mal - I managed to build it myself. Your fix works well, thanks a lot!

@pfarrelle

Copy link
Copy Markdown

I would just like to add that this fix works for me as well. My focus is using bear to return tags and this code works perfectly - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants